adds prototype of capabilities decorator #23

willemolding · 2018-10-12T06:02:37Z

Replaces @zome_function decorator with @capability('capabilityName')
Correctly creates multiple capability directories and jsons which are detected by the holochain core

Closes #22

willemolding · 2018-10-12T06:06:59Z

How do we like this as an example? It feels pretty good to me but seems kind of awkward that a single typo can create a whole new capability.

Another idea might be to use namespaces to represent capabilities e.g.

@capability
namespace main {
  function zomeFunction1() {}
  function zomeFunction2() {}
}

This would reduce the number of decorators needed and eliminate the @zome_function one entirely as all functions in a capability namespace would be zome functions

Connoropolous · 2018-10-12T10:57:49Z

examples/appSpec/test/dist/bundle.js

@@ -0,0 +1,48 @@
+"use strict";
+
+var _testHelper = require("./test-helper");


How come this file is added?

Connoropolous · 2018-10-12T10:58:46Z

examples/appSpec/src/main.rs

@@ -85,7 +85,7 @@ mod tests {
    #[test]
    fn test_init_globals() {
        let mut hc = setup_hc();
-        let globals_result = hc.call("three", "main", "test_init_globals", "");
+        let globals_result = hc.call("three", "other_capability", "test_init_globals", "");


This file shouldn't exist anymore...

Connoropolous

I like your other suggestion too, but I feel good about just going with this for now, and trying it

maackle · 2018-10-15T00:36:56Z

examples/appSpec/zomes/three/code/index.ts

@@ -13,7 +13,7 @@ import {

 /*----------  Public Functions  ----------*/

-@zome_function
+@capability('main')


Dept. of Names Dept. Q: does it make more sense to describe each of these functions as a "capability" or a "zome function"? I like that calling the decorator capability makes it clear what the argument should be, but using @zomeFunction(capabilityName) makes more sense to me with regard to what it actually is decorating.

Willem and I were just chatting, and his latest thought was this...

@capability('agent') namespace main { ... }

where multiple zome functions are defined within the namespace. agent refers to the access membrane

adds prototype of capabilities decorator

196fad8

willemolding requested review from Connoropolous and maackle October 12, 2018 06:02

Connoropolous reviewed Oct 12, 2018

View reviewed changes

Connoropolous approved these changes Oct 12, 2018

View reviewed changes

Connoropolous added this to In progress in by DevCamp? Oct 13, 2018

maackle reviewed Oct 15, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds prototype of capabilities decorator #23

adds prototype of capabilities decorator #23

willemolding commented Oct 12, 2018

willemolding commented Oct 12, 2018 •

edited

Connoropolous Oct 12, 2018

Connoropolous Oct 12, 2018

Connoropolous left a comment

maackle Oct 15, 2018

Connoropolous Oct 15, 2018

		@@ -0,0 +1,48 @@
		"use strict";

		var _testHelper = require("./test-helper");

adds prototype of capabilities decorator #23

Are you sure you want to change the base?

adds prototype of capabilities decorator #23

Conversation

willemolding commented Oct 12, 2018

willemolding commented Oct 12, 2018 • edited

Connoropolous Oct 12, 2018

Choose a reason for hiding this comment

Connoropolous Oct 12, 2018

Choose a reason for hiding this comment

Connoropolous left a comment

Choose a reason for hiding this comment

maackle Oct 15, 2018

Choose a reason for hiding this comment

Connoropolous Oct 15, 2018

Choose a reason for hiding this comment

willemolding commented Oct 12, 2018 •

edited