-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
That was fast! I just created the ticket, got my tea from the kitchen and there is already a PR for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I've tried running it over the app-spec-rust repo and it still includes dot-files..
Can we have a test in here please? :)
It seems that dot-files are being ignored, but not dot-directories, like .git for instance... |
Cool, it works! Just missing documentation ;) |
803bb83
to
0243ea5
Compare
Please review, need merge. Does ignore dot-files and files mentioned in .hcdevignore. app-spec-rust already has a .hcdevignore file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
README.md
Outdated
@@ -62,6 +62,18 @@ So in a given Zome we have two things: | |||
|
|||
In order for Holochain to run your app, you have to build your code into a single packaged file. Those instructions follow. | |||
|
|||
## Ignoring files | |||
|
|||
Sometimes, you'll want to exclude files in your project directory to get a straight .hcpkg file that can be understood by Holochain. In oder to do that, just create a `.hcdevignore` file. It has a simmilar structure to `.gitignore` files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling -> In "order"
And "similar"
README.md
Outdated
@@ -62,6 +62,18 @@ So in a given Zome we have two things: | |||
|
|||
In order for Holochain to run your app, you have to build your code into a single packaged file. Those instructions follow. | |||
|
|||
## Ignoring files | |||
|
|||
Sometimes, you'll want to exclude files in your project directory to get a straight .hcpkg file that can be understood by Holochain. In order to do that, just create a `.hcdevignore` file. It has a similar structure to `.gitignore` files: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the risk of being "that guy" and bike shedding this to death... what do you think of just .hcignore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the tool also recognizes .ignore
files, so we could do just tha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use .hcignore
rather than .hcdevignore
because we know the command name will change.
closes #14