Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Ignore dotfiles by default #15

Merged
merged 13 commits into from
Sep 4, 2018
Merged

Ignore dotfiles by default #15

merged 13 commits into from
Sep 4, 2018

Conversation

sphinxc0re
Copy link
Contributor

closes #14

@sphinxc0re sphinxc0re changed the title ignore dotfiles by default [WIP] ignore dotfiles by default Aug 27, 2018
@lucksus
Copy link
Collaborator

lucksus commented Aug 27, 2018

That was fast! I just created the ticket, got my tea from the kitchen and there is already a PR for it.
Cheers! :D

@sphinxc0re sphinxc0re changed the title [WIP] ignore dotfiles by default Ignore dotfiles by default Aug 27, 2018
Copy link
Collaborator

@lucksus lucksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I've tried running it over the app-spec-rust repo and it still includes dot-files..

Can we have a test in here please? :)

@lucksus
Copy link
Collaborator

lucksus commented Aug 27, 2018

It seems that dot-files are being ignored, but not dot-directories, like .git for instance...

@lucksus
Copy link
Collaborator

lucksus commented Aug 31, 2018

Cool, it works! Just missing documentation ;)

@lucksus
Copy link
Collaborator

lucksus commented Aug 31, 2018

Please review, need merge. Does ignore dot-files and files mentioned in .hcdevignore. app-spec-rust already has a .hcdevignore file.

Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

README.md Outdated
@@ -62,6 +62,18 @@ So in a given Zome we have two things:

In order for Holochain to run your app, you have to build your code into a single packaged file. Those instructions follow.

## Ignoring files

Sometimes, you'll want to exclude files in your project directory to get a straight .hcpkg file that can be understood by Holochain. In oder to do that, just create a `.hcdevignore` file. It has a simmilar structure to `.gitignore` files:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling -> In "order"
And "similar"

README.md Outdated
@@ -62,6 +62,18 @@ So in a given Zome we have two things:

In order for Holochain to run your app, you have to build your code into a single packaged file. Those instructions follow.

## Ignoring files

Sometimes, you'll want to exclude files in your project directory to get a straight .hcpkg file that can be understood by Holochain. In order to do that, just create a `.hcdevignore` file. It has a similar structure to `.gitignore` files:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the risk of being "that guy" and bike shedding this to death... what do you think of just .hcignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the tool also recognizes .ignore files, so we could do just tha

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use .hcignore rather than .hcdevignore because we know the command name will change.

@thedavidmeister thedavidmeister merged commit ee767b4 into master Sep 4, 2018
@sphinxc0re sphinxc0re deleted the ignore-dotfiles branch September 4, 2018 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants