Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

add .gitignore to init, and rename init in code #75

Merged
merged 5 commits into from
Oct 22, 2018
Merged

add .gitignore to init, and rename init in code #75

merged 5 commits into from
Oct 22, 2018

Conversation

Connoropolous
Copy link
Collaborator

@Connoropolous Connoropolous commented Oct 21, 2018 •
edited
Loading

@Connoropolous Connoropolous self-assigned this Oct 21, 2018
@Connoropolous Connoropolous added this to In progress in by DevCamp Oct 21, 2018
maackle
maackle suggested changes Oct 21, 2018
View reviewed changes
Copy link
Member

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than just the suggestion of simplifying the .gitignore. Especially adding node_modules/ as an ignore rule to ignore it in any and all subdirectories.

src/cli/git-scaffold/.gitignore Outdated Show resolved Hide resolved
maackle and others added 2 commits October 21, 2018 15:12
@maackle @Connoropolous
Update src/cli/git-scaffold/.gitignore
5edde1e 
Co-Authored-By: Connoropolous <connorturland@gmail.com>
@Connoropolous
Update .gitignore
4876275
@Connoropolous
Copy link
Collaborator Author

@maackle cool thanks. Integrated

zippy
zippy approved these changes Oct 22, 2018
View reviewed changes
Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

@Connoropolous Connoropolous merged commit 0e4b660 into master Oct 22, 2018
@Connoropolous Connoropolous deleted the 21-add-gitignore branch October 22, 2018 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zippy zippy zippy approved these changes

@maackle maackle maackle approved these changes

@lucksus lucksus Awaiting requested review from lucksus

@thedavidmeister thedavidmeister Awaiting requested review from thedavidmeister

@sphinxc0re sphinxc0re Awaiting requested review from sphinxc0re

@StaticallyTypedAnxiety StaticallyTypedAnxiety Awaiting requested review from StaticallyTypedAnxiety

@ddd-mtl ddd-mtl Awaiting requested review from ddd-mtl

Assignees

@Connoropolous Connoropolous

Labels
None yet
Projects
No open projects
by DevCamp
  
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Connoropolous @zippy @maackle