-
Notifications
You must be signed in to change notification settings - Fork 268
Conversation
Dont merge until the profiler is run(can still review) just need to confirm that the space issue has been fixed. Edit : This has been confirmed, investigating why pickledb is 3 times larger than file. Findings : File is larger because a further encoding is done on the content which is an encoded type in itself. This sounds like something that should be talked about architecturally |
@@ -83,11 +85,13 @@ fn make_config(instance_data: Vec<InstanceData>, logger: LoggerConfiguration) -> | |||
|
|||
let agent_id = agent_config.id.clone(); | |||
let dna_id = dna_config.id.clone(); | |||
let temp = tempdir().expect("test was supposed to create temp dir"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking up tempdir's docs because I was wondering if that is a unique directory since we don't want multiple test instances share the same CAS. It says that the tempdir gets removed when TempDir
is dropped. This happens a few lines below, right? The conductor will recreate the the path I guess but then nothing will delete it, so it actually is not temporary. This might cause mysterious problems later on.. Not sure if we actually want to merge pickle as default for nodejs conductor into develop.. We might want to if it really is faster than MemoryStorage..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I think since memory is the fastest and this is for the use in the nodejs we should still go back to memory. I will revert this back asap
Benchmarks have been run and flame graph is up on realtimeboard test bench_file_eav_many_to_one ... bench: 183,641,550 ns/iter (+/- 131,852,367) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Hope this gets merged asap! :)
Maybe we should change the title of this PR though since it's now only fixing pickledb without setting it in the nodejs conductor.
Please check one of the following, relating to the CHANGELOG, which should be updated if relevant
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)