Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

(un)install conductor #1689

Merged
merged 2 commits into from Aug 29, 2019
Merged

(un)install conductor #1689

merged 2 commits into from Aug 29, 2019

Conversation

thedavidmeister
Copy link
Contributor

PR summary

reinstates the conductor install/uninstall from holonix

see https://forum.holochain.org/t/fyi-hc-conductor-rust-commands-were-dropped-from-holonix/728/2

[nix-shell:~/holochain-rust]$ which holochain
/nix/store/x5fvm8k15glw3qzcjfqy07pvyiib3273-holochain/bin/holochain

[nix-shell:~/holochain-rust]$ hc-conductor-install 
  Installing holochain v0.0.29-alpha2 (/home/thedavidmeister/holochain-rust/conductor)
    Updating crates.io index
    Updating git repository `https://github.com/holochain/jsonrpc`
    Finished release [optimized] target(s) in 5.38s
  Installing /home/thedavidmeister/holochain-rust/.cargo/bin/holochain
   Installed package `holochain v0.0.29-alpha2 (/home/thedavidmeister/holochain-rust/conductor)` (executable `holochain`)

[nix-shell:~/holochain-rust]$ which holochain 
/home/thedavidmeister/holochain-rust/.cargo/bin/holochain

[nix-shell:~/holochain-rust]$ hc-conductor-uninstall 
dropping holochain conductor binary from cargo home directory

[nix-shell:~/holochain-rust]$ which holochain
/nix/store/x5fvm8k15glw3qzcjfqy07pvyiib3273-holochain/bin/holochain

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

Please check one of the following, relating to the CHANGELOG-UNRELEASED.md

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

Copy link
Contributor

@philipbeadle philipbeadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx for the roll back.

@thedavidmeister thedavidmeister merged commit 558fc45 into develop Aug 29, 2019
@zippy zippy deleted the 2019-08-29-conductor-binary branch October 4, 2019 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants