Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Adds abiity to pass DNA properties in hc package #1720

Merged
merged 8 commits into from
Oct 7, 2019

Conversation

willemolding
Copy link
Collaborator

@willemolding willemolding commented Sep 25, 2019

PR summary

Closes #1715

Adds a new parameter to hc package which allows a developer to pass a stringified JSON object to be inserted into the .dna.json as the DNA properties.

This can be used to quickly fork a DNA from its source code.

changelog

Please check one of the following, relating to the CHANGELOG-UNRELEASED.md

  • this is a code change that effects some consumer (e.g. zome developers) of holochain core so it is added to the CHANGELOG-UNRELEASED.md (linked above), with the format - summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
  • this is not a code change, or doesn't effect anyone outside holochain core development

Copy link
Contributor

@StaticallyTypedAnxiety StaticallyTypedAnxiety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Collaborator

@timotree3 timotree3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I contributed some suggestions, feel free to take them or not. :)

cli/src/main.rs Outdated Show resolved Hide resolved
cli/src/main.rs Outdated Show resolved Hide resolved
cli/src/main.rs Show resolved Hide resolved
@willemolding
Copy link
Collaborator Author

Thanks for the review @timotree3

Copy link
Collaborator

@timotree3 timotree3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I like the way you rewrote that block even better than I like my own suggestion! :-)

cli/src/main.rs Outdated Show resolved Hide resolved
@willemolding willemolding merged commit 131030e into develop Oct 7, 2019
@willemolding willemolding deleted the feature/hc-package-with-params branch October 7, 2019 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hc package --settings="{\"prop_name\":\"prop_value\"}"
3 participants