This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Sim1h + deadlocks fixed + app-spec update + ... #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b3h-client-protocol-integration-transport-memory
…github.com:holochain/holochain-rust into lib3h-client-protocol-integration-transport-memory
…github.com:holochain/holochain-rust into lib3h-client-protocol-integration-transport-memory
…github.com:holochain/holochain-rust into lib3h-client-protocol-integration-transport-memory
…st into sim1h-integration
maackle
suggested changes
Oct 3, 2019
Comment on lines
3
to
9
| /////////////////////////////////// | ||
| /// | ||
| /// | ||
| /// TODO | ||
| /// | ||
| /// | ||
| //////////////////////////////////// |
There was a problem hiding this comment.
This whole file needs to be redone for try-o-rama...
lucksus
changed the title
Co-Authored-By: Michael Dougherty <michael.dougherty@holo.host>
…st into sim1h-integration
maackle
approved these changes
Oct 3, 2019
This was referenced Oct 4, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This is an aggregated PR that includes several parts that in concert constitute a big shift in terms of usability and reliability.
UUIDto DNA configs, which also deactivates the DNA hash check if set (Add UUID to DnaConfig and disable integrity check if UUID is specified #1724, fixes Make DNA hash optional again #1600)testing/benchmarking notes
Running app-spec locally with sim1h can be done through the new nix-shell command
hc-app-spec-test-sim1h. It is configured though to assume a dynamodb instance running onhttp://localhost:8000. The new nix-shell commanddynamodb-memorystarts an in-memory instance on that port.followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)