This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sim2h Integration #1744
Sim2h Integration #1744
Changes from 51 commits
0f145c6
a73fe98
497d454
b3e2638
5f78c27
67f3c1e
aad0a39
8fe33ad
9fbb332
a27b59f
b6c4285
e583ac6
ec1a0f8
2928e85
08b8e0f
952c02c
320f92b
9c07d00
8bb0923
53998d7
0e37559
4704ec6
f3d6ad1
f472784
886150d
a9f4d31
e5e4e26
4cade7a
54709a4
8c884b7
5350d3e
778f91e
c374752
1ef69d7
27f6ba6
04a0d13
23a5119
86977eb
293dc3b
dffe1f1
4afb893
d4ed54e
a8e8863
f916fe8
c5ada9b
f9340a1
c9874ac
c168653
36fb968
84994bf
b39f5a7
5d94485
9b9b7a2
c476432
4293b86
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AshantiMutinta, take note of this new crate. It only includes this
ConductorApi
struct which is a proxy for the conductor api that does not depend on anything in theconductor_api
crate - which is good because we can't depend on that in thenet
crate without creating cyclic dependencies.ConductorApi
was incore
before we can't depend on that either.With the repository clean-up that we discussed yesterday, I would suggest with rename this crate to
conductor_api
since the currentconductor_api
will beconductor_lib
, right?