Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Remove ability to unpack .dna.json #1864

Merged
merged 19 commits into from
Nov 12, 2019
Merged

Conversation

willemolding
Copy link
Collaborator

@willemolding willemolding commented Nov 12, 2019

PR summary

Closes #1859

This has been causing some issues lately (#1846 and #1824) and not getting much use as a feature. This PR removes the meta data from the .dna.json as well as preventing it from slurping up all the random files you forget to add the the .hcignore. Now it will only slurp up WASM that is in a directory with a .hcbuild. This should prevent a lot of issues people are having with large bundles among other things.

It also removes the hc unpackage option from the CLI

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@thedavidmeister
Copy link
Contributor

also note that holonix is in an unreleasable state with develop failing builds on all platforms due to the scaffolding repos generating zomes that show errors

e.g. https://circleci.com/gh/holochain/holonix/1279

@zippy
Copy link
Member

zippy commented Nov 12, 2019

Hey there. Looks like you got some cruft around trycp in this branch by accident. I'm guessing you did work on this between when two portions of trycp were added in, and so this PR is deleting a bunch of important stuff that got merged into develop later.

Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I guess maybe it was a case of YAGNI when we originally implemented it. The real use-case was packaging for use by the conductor, not for use by other coders. And given the problems it's cause I'm ok removing it now.

However, please fix the merge issue that's deleting trycp code!

@willemolding
Copy link
Collaborator Author

Hey there. Looks like you got some cruft around trycp in this branch by accident. I'm guessing you did work on this between when two portions of trycp were added in, and so this PR is deleting a bunch of important stuff that got merged into develop later.

Ah yep good catch. Fixed

@thedavidmeister thedavidmeister merged commit 5152cfc into develop Nov 12, 2019
@neonphog neonphog deleted the remove-meta-option branch March 6, 2020 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is the ability to unpack directory structure from .dna.json really needed? (i.e. __META__ data)
4 participants