-
Notifications
You must be signed in to change notification settings - Fork 269
Conversation
also note that holonix is in an unreleasable state with develop failing builds on all platforms due to the scaffolding repos generating zomes that show errors |
…ust into remove-meta-option
Hey there. Looks like you got some cruft around trycp in this branch by accident. I'm guessing you did work on this between when two portions of trycp were added in, and so this PR is deleting a bunch of important stuff that got merged into develop later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I guess maybe it was a case of YAGNI when we originally implemented it. The real use-case was packaging for use by the conductor, not for use by other coders. And given the problems it's cause I'm ok removing it now.
However, please fix the merge issue that's deleting trycp code!
…ust into remove-meta-option
Ah yep good catch. Fixed |
PR summary
Closes #1859
This has been causing some issues lately (#1846 and #1824) and not getting much use as a feature. This PR removes the meta data from the .dna.json as well as preventing it from slurping up all the random files you forget to add the the
.hcignore
. Now it will only slurp up WASM that is in a directory with a.hcbuild
. This should prevent a lot of issues people are having with large bundles among other things.It also removes the
hc unpackage
option from the CLIchangelog
documentation