Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Run hApp-bundles during develpment with `hc run` #1939
Currently hApp developers can only run very simple, one DNA hApps with
Every hApp that is a bit more complex (multiple DNAs, bridges, etc.) can't be easily run during development. This lead devs to run the production conductor with a real conductor config. That in turn required them to couple the UI to this development setup for instance by injecting interface URLs/ports via ENVs. These patterns are not compatible with production deployments.
What hApp devs should do is start their hApp by writing a hApp-bundle as the hApps manifest. That conveys all information to setup any run-time to run the hApp (be it dev, production Holoscape or production Holo).
This PR adds the needed capability to
This makes it possible to run complex hApp setups with multiple DNAs and bridges without having to write and maintain a conductor config. With that it enables a hApp development workflow that is centered around hApp-bundles from start and thus future-proof for deployment. It solves the problems discussed in #1600.
Add functionality to
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)
zippy left a comment
This looks pretty good, but I don't see any tests whatsoever, which worries me, because this is the kind of thing that folks will start to rely on. Also I thought that at one point we removed from the conductor the ability to do static serving, so I'm surprised that's still here. Are you sure that still works?
thedavidmeister left a comment
i do approve and am also concerned about the lack of tests around this and
a lot of my time recently has been spent retroactively fixing
also i appreciate that adding tests might need to be a "next sprint" thing