Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Set hachiko to strict mode #2001

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Set hachiko to strict mode #2001

wants to merge 8 commits into from

Conversation

maackle
Copy link
Member

@maackle maackle commented Dec 19, 2019

PR summary

This will cause a test failure whenever hachiko times out. Since we have been having lots of uncertainty around hachiko and our consistency model, which are cornerstones of our scenario testing strategy, it's pretty important that have confidence in them. So, let's make failures red.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@maackle
Copy link
Member Author

maackle commented Dec 22, 2019

Curiously, we get lots of hachiko timeouts in CI, but none locally. Also, when I run a CI build with SSH and then run the test again on the same machine, it passes without timeouts.

When it does timeout, it causes the whole test to hang indefinitely because a conductor is not getting killed. And then the CI test can run for hours until it's manually canceled...

@maackle
Copy link
Member Author

maackle commented Dec 22, 2019

I think there's just something wrong with the way conductors connect to sim2h in CircleCI. I see similar failures when I run the tests locally without sim2h running...

We'll just have to keep an eye on this until we figure out what might be wrong 🤷‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant