Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Link Pagination #2092

Merged
merged 40 commits into from
Feb 6, 2020
Merged

Link Pagination #2092

merged 40 commits into from
Feb 6, 2020

Conversation

StaticallyTypedAnxiety
Copy link
Contributor

PR summary

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@StaticallyTypedAnxiety StaticallyTypedAnxiety changed the title Link Pagination [WIP]Link Pagination Jan 30, 2020
willemolding and others added 29 commits February 4, 2020 17:45
@willemolding @StaticallyTypedAnxiety
query::get_links to return only the list of addresses of the LinkAdd …
6d00729 
…entries
@willemolding @StaticallyTypedAnxiety
completes refactor of link network calls
e106883
@willemolding @StaticallyTypedAnxiety
fmt
5fccce8
@willemolding @StaticallyTypedAnxiety
clippify
e662a64
@willemolding @StaticallyTypedAnxiety
fmt
49fd92e
@willemolding @StaticallyTypedAnxiety
any any LinkAdd entries cannot be retrieved fail with the error
2bae020
@willemolding @StaticallyTypedAnxiety
propagte crud status stored on links
f1a373f
@willemolding @StaticallyTypedAnxiety
rewrite remove link with new get_links refactor
31f127b
@willemolding @StaticallyTypedAnxiety
revert remove_link back to not filtering to test app spec
7cb3a62
@willemolding @StaticallyTypedAnxiety
fmt
f6ff693
@willemolding @StaticallyTypedAnxiety
simply remove links logic
be6d061
@willemolding @StaticallyTypedAnxiety
merge develop
d491879
@StaticallyTypedAnxiety
fixed remove_link
b5fcece
@StaticallyTypedAnxiety
rust fmt
870b877
@StaticallyTypedAnxiety
removed println
556b42a
@StaticallyTypedAnxiety
removed random clone
05c94fd
@StaticallyTypedAnxiety
Update links.rs
15dd0da
@StaticallyTypedAnxiety
cleaned up comments
d58181e
@willemolding @StaticallyTypedAnxiety
fmt
344b5a0
@StaticallyTypedAnxiety
implemented pagination
9963fe3
@StaticallyTypedAnxiety
fixed delimeter
2349d65
@StaticallyTypedAnxiety
Wrote app_spec tests
7443617
@StaticallyTypedAnxiety
made changes regarding time and view
24b4de2
@StaticallyTypedAnxiety
paginated link fixes
1226b6f
@StaticallyTypedAnxiety
remove println
f41066e
@StaticallyTypedAnxiety
fixed comment
8db253e
@StaticallyTypedAnxiety
restored tests
f695d79
@StaticallyTypedAnxiety
disable validate-agent-test
e1547f7
@StaticallyTypedAnxiety
Update index.js
0392836
@StaticallyTypedAnxiety StaticallyTypedAnxiety changed the title [WIP]Link Pagination Link Pagination Feb 5, 2020
zippy
zippy approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please add an item to change log and docs.

lucksus
lucksus approved these changes Feb 6, 2020
View reviewed changes
Copy link
Collaborator

@lucksus lucksus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@StaticallyTypedAnxiety StaticallyTypedAnxiety merged commit b25248b into develop Feb 6, 2020
@neonphog neonphog deleted the pagination branch March 5, 2020 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zippy zippy zippy approved these changes

@lucksus lucksus lucksus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StaticallyTypedAnxiety @zippy @lucksus @willemolding