This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
implemented different types of pagination #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…holochain/holochain-rust into pagination_second_iteration
zippy
reviewed
Feb 12, 2020
| @@ -1,4 +1,5 @@ | |||
| const { one, two } = require('../config') | |||
| const sleep = require('sleep') | |||
|
|
|||
| module.exports = scenario => { | |||
| scenario('delete_post', async (s, t) => { | |||
There was a problem hiding this comment.
Why is this scenario called "delete_post"
There was a problem hiding this comment.
Woops that is not a new scenario but I have just added sleep in there :)
zippy
approved these changes
Feb 12, 2020
Co-Authored-By: Eric Harris-Braun <eric@harris-braun.com>
freesig
suggested changes
Feb 12, 2020
Co-Authored-By: Tom <tomrgowan@gmail.com>
freesig
approved these changes
Feb 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
-Second iteration of pagination adds a new type which can paginate by time and limit
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation