Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented different types of pagination #2110

Merged
merged 10 commits into from Feb 12, 2020

Conversation

@AshantiMutinta
Copy link
Contributor

AshantiMutinta commented Feb 12, 2020

PR summary

-Second iteration of pagination adds a new type which can paginate by time and limit

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

fmt
@AshantiMutinta AshantiMutinta requested review from lucksus and zippy Feb 12, 2020
@@ -1,4 +1,5 @@
const { one, two } = require('../config')
const sleep = require('sleep')

module.exports = scenario => {
scenario('delete_post', async (s, t) => {

This comment has been minimized.

Copy link
@zippy

zippy Feb 12, 2020

Member

Why is this scenario called "delete_post"

This comment has been minimized.

Copy link
@AshantiMutinta

AshantiMutinta Feb 12, 2020

Author Contributor

Woops that is not a new scenario but I have just added sleep in there :)

@zippy
zippy approved these changes Feb 12, 2020
Copy link
Member

zippy left a comment

Minor update to docs, looks great.

doc/holochain_101/src/links/get_links.md Outdated Show resolved Hide resolved
Co-Authored-By: Eric Harris-Braun <eric@harris-braun.com>
Copy link
Contributor

freesig left a comment

I think just run fmt but everything else looks good

app_spec/zomes/simple/code/src/lib.rs Outdated Show resolved Hide resolved
AshantiMutinta and others added 2 commits Feb 12, 2020
Co-Authored-By: Tom <tomrgowan@gmail.com>
@AshantiMutinta AshantiMutinta merged commit 77e3b1a into develop Feb 12, 2020
6 checks passed
6 checks passed
ci/circleci: app-spec-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cli-tests Your tests passed on CircleCI!
Details
ci/circleci: fmt Your tests passed on CircleCI!
Details
ci/circleci: stress-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: wasm-conductor-tests Your tests passed on CircleCI!
Details
@neonphog neonphog deleted the pagination_second_iteration branch Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.