This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is going to need dumping just the response to a file maybe JSON encoded to be usefull? |
Yep, mainly why I left this as WIP. The current plain debug output is hard to read.. |
zippy
reviewed
Feb 25, 2020
Fails if message debug data is bigger than max tungstenite message size! |
Co-Authored-By: Eric Harris-Braun <eric@harris-braun.com>
zippy
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOOT!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Adds a
WireMessge::Debug
andWireMessage::DebugResponse(BTreeMap<SpaceHash, String>)
to retrieve all space data as JSON serialized string.hc
can request this debug state dump and write it to file(s) (each space data into a separate one):testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
Make this optional (per command line parameter / configuration) such that public sim2h servers don't offer potential sensitive information to everybody
changelog
documentation