This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
await on join #2137
Merged
await on join #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonphog
reviewed
Feb 28, 2020
crates/sim2h/src/sim2h_im_state.rs
Outdated
| let f = self.new_connection(space_hash, agent_id, uri); | ||
| tokio::task::spawn(f); | ||
| f.await |
There was a problem hiding this comment.
My intention was that functions prefixed with spawn_ would not return futures (or anything else) because they spawn the task.
If we don't need this, we can just delete this whole function - and lib.rs can call new_connection() directly : )
neonphog
reviewed
Feb 28, 2020
crates/sim2h/src/lib.rs
Outdated
| @@ -522,17 +531,20 @@ fn spawn_handle_message_hello( | |||
| } | |||
| } | |||
|
|
|||
| fn spawn_handle_message_join_space( | |||
| async fn spawn_handle_message_join_space( | |||
There was a problem hiding this comment.
similarly, remove the spawn_ prefix here if that's not what we're doing.
neonphog
approved these changes
Feb 28, 2020
zippy
approved these changes
Feb 28, 2020
zippy
approved these changes
Feb 28, 2020
Co-Authored-By: Connor Turland <connorturland@gmail.com>
maackle
reviewed
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This awaits on the new connection future instead of just spawning it because otherwise the
Lib3hToClient::HandleGetGossipingEntryListandLib3hToClient::HandleGetAuthoringEntryListmessages get sent and can be responded to before the join is complete. This leads to the responses to those messages being thrown away. Then the agents id's never actually get into the DHT.testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation