Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

CLI additions #2161

Merged
merged 6 commits into from
Mar 20, 2020
Merged

CLI additions #2161

merged 6 commits into from
Mar 20, 2020

Conversation

maackle
Copy link
Member

@maackle maackle commented Mar 18, 2020

PR summary

  • adds --uuid option to hc hash
  • adds --files option to hc sim2h-client
    • if set, the previous behavior of writing to multiple files applies
    • if not, a single JSON object is printed to stdout

both are needed for what I'm working on, a tryorama check that asserts that client state dumps are consistent with sim2h server state

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@maackle
Copy link
Member Author

maackle commented Mar 19, 2020

Tests are flaky after merging develop in... app spec failed once, and now stress tests are

@zippy zippy merged commit 5d34688 into develop Mar 20, 2020
@Connoropolous
Copy link
Collaborator

@maackle this looks useful!
I have a CLI item high on my wishlist, for hc hash , which is to get a machine readable version of it!

Currently have to do something like this:
hc hash --path dna/acorn.dna.json | awk '/DNA Hash: /{print $NF}' | tr -d '\n'
https://github.com/h-be/acorn-release/blob/f421be88b3e714c1bd5ed81b4addfc36097db025/nix/acorn/default.nix#L11-L12

How is holochain team handling user feedback, feature requests, etc these days?
In my experience, creating github issues isn't very effective.

@maackle
Copy link
Member Author

maackle commented Apr 3, 2020

@Connoropolous I want it to be human-readable too, I think in general we are loose about what we print to stdout so that makes it hard to guarantee. Unfortunately creating an issue may still be the best bet...

@Connoropolous
Copy link
Collaborator

I think there was another cli command that had a 'clean' option or something to make it machine readable as an alternative. That's what I was thinking of

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants