This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Rename container to conductor #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connoropolous
changed the title
|
there would be some follow up work to this, with the npm package rename |
Connoropolous
suggested changes
Feb 3, 2019
maackle
reviewed
Feb 3, 2019
maackle
reviewed
Feb 3, 2019
maackle
reviewed
Feb 3, 2019
maackle
approved these changes
Feb 3, 2019
There was a problem hiding this comment.
What do you think about capitalizing Conductor? It's a generic word that we are using in a creative way to refer to something specific -- and when it's lowercased it seems like something we're throwing around nonchalantly, and would be confusing for people who don't yet know that it's a special thing. Capitalization would signal to them that it's something to research.
It feels like a proper noun.
Co-Authored-By: zippy <eric@harris-braun.com>
Co-Authored-By: zippy <eric@harris-braun.com>
Co-Authored-By: zippy <eric@harris-braun.com>
lucksus
approved these changes
Feb 4, 2019
Connoropolous
approved these changes
Feb 4, 2019
|
I'm working on the merge conflicts for this branch |
|
Merge conflicts resolved, if CI passes, I'm merging |
…n/holochain-rust into containter-to-conductor
…n/holochain-rust into containter-to-conductor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename Container to Conductor
Rename
holochain_containerto justholochain