Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow descending order of chain query filter #1539

Merged
merged 6 commits into from Sep 8, 2022
Merged

Allow descending order of chain query filter #1539

merged 6 commits into from Sep 8, 2022

Conversation

maackle
Copy link
Member

@maackle maackle commented Aug 23, 2022

Summary

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

neonphog
neonphog reviewed Aug 23, 2022
View reviewed changes
crates/holochain_state/src/source_chain.rs
);
sql.push_str(if query.order_descending {" DESC"} else {" ASC"});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - this manual string manipulation frustrates me every time I see it. But your fix is good within the context of this strategy already being used : )

@maackle maackle merged commit 631cbf4 into develop Sep 8, 2022
@maackle maackle deleted the chain-query-order branch September 8, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neonphog neonphog neonphog approved these changes

@thedavidmeister thedavidmeister Awaiting requested review from thedavidmeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maackle @neonphog