Make OpBasis AnyLinkableHash instead of AnyDhtHash #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maackle
commented
Sep 29, 2022
Comment on lines
-136
to
-138
| impl From<AnyLinkableHash> for AnyDhtHash { | ||
| fn from(hash: AnyLinkableHash) -> Self { | ||
| hash.retype(hash_type::AnyDht::Entry) |
There was a problem hiding this comment.
This From was invalid, so I flipped it around to make it valid.
neonphog
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since
RegisterAddLinkandRegisterRemoveLinkare ops, and the link base is the op's basis, and link bases areAnyLinkableHash, then it follows that the op basis is actually that, notAnyDhtHash, which excludes the External hash type. This adjusts the code accordingly.There was also a
From<AnyLinkableHash> for AnyDhtHash, which is invalid because the External variant has no mapping in AnyDhtHash, so I removed it. It is also no longer needed, since the places it was used are no longer relevant with the type change.TODO: