-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2023 01 24 block sketch #1828
2023 01 24 block sketch #1828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: David Braden <neonphog@gmail.com>
…ain into 2023-01-24-block-sketch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Also looks like most of the code here is to implement logic for time-bounded blocks. If that's fully done, I guess it will be helpful, otherwise I wonder if we need it?
@maackle yes it's fully done afaik, i tested all the scenarios that i thought of while working on it |
M::initial(include_str!("sql/conductor/schema/0.sql")), | ||
M { | ||
forward: include_str!("sql/conductor/schema/1.sql").into(), | ||
_schema: "".into(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to have a good dev script for printing out the current schema for each db, if we're not gonna have it committed to the repo.
Summary
sketches out
future work
TODO: