Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023 01 24 block sketch #1828

Merged
merged 38 commits into from
Feb 27, 2023
Merged

2023 01 24 block sketch #1828

merged 38 commits into from
Feb 27, 2023

Conversation

thedavidmeister
Copy link
Contributor

@thedavidmeister thedavidmeister commented Jan 27, 2023

Summary

sketches out

  • structs for block/unblock
  • hdk interface to it
  • database table to track blocks
  • reads/writes to block/unblock
  • removes lossy timestamp handling for i64 micros in db

future work

  • put things in and out of the database

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading

Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@maackle maackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Also looks like most of the code here is to implement logic for time-bounded blocks. If that's fully done, I guess it will be helpful, otherwise I wonder if we need it?

crates/holochain_sqlite/src/schema.rs Outdated Show resolved Hide resolved
crates/holochain_zome_types/src/block.rs Show resolved Hide resolved
@thedavidmeister
Copy link
Contributor Author

Looks good. Also looks like most of the code here is to implement logic for time-bounded blocks. If that's fully done, I guess it will be helpful, otherwise I wonder if we need it?

@maackle yes it's fully done afaik, i tested all the scenarios that i thought of while working on it

M::initial(include_str!("sql/conductor/schema/0.sql")),
M {
forward: include_str!("sql/conductor/schema/1.sql").into(),
_schema: "".into(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have a good dev script for printing out the current schema for each db, if we're not gonna have it committed to the repo.

@thedavidmeister thedavidmeister enabled auto-merge (squash) February 27, 2023 16:49
@thedavidmeister thedavidmeister merged commit a42ad1b into develop Feb 27, 2023
@thedavidmeister thedavidmeister deleted the 2023-01-24-block-sketch branch February 27, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants