Remove impossible HoloHash From conversions and make HoloHash::retype() private
#2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maackle
requested review from
thedavidmeister,
neonphog,
steveej,
ThetaSinner and
jost-s
neonphog
approved these changes
Apr 6, 2023
This reverts commit a149ca0.
jost-s
approved these changes
Apr 6, 2023
ThetaSinner
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had a bunch of From impls going from essentially an enum (a sum type) into one of its variants, which is ill-advised because there's no guarantee that the enum is of the expected variant (like going from AnyDhtHash into EntryHash, when it was actually an ActionHash).
This removes those Froms and make
retypeprivate so this kind of unsafe "casting" can't be done.TODO: