TK-02545: 2020 08 03 validate links #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chain into 2020-08-03-validate-links
…lochain into 2020-08-03-validate-links
thedavidmeister
changed the base branch from
develop
to
2020-08-05-entry-defs-macro
thedavidmeister
changed the title
thedavidmeister
changed the title
thedavidmeister
changed the base branch from
2020-08-05-entry-defs-macro
to
develop
…-03-validate-links
…chain into 2020-08-03-validate-links
|
tru loc changed |
neonphog
reviewed
Aug 6, 2020
| } | ||
| } | ||
| } | ||
| _ => {} |
There was a problem hiding this comment.
maybe brief comment on why it's ok to ignore all other variants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements callbacks to validate links
sits on top of #276
followups: