Check authority on flush #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maackle
reviewed
Aug 17, 2021
neonphog
reviewed
Aug 17, 2021
| @@ -510,6 +516,12 @@ impl SourceChain { | |||
| let entries = scratch.drain_entries().collect::<Vec<_>>(); | |||
| SourceChainResult::Ok((headers, ops, entries)) | |||
| })?; | |||
| let mut ops_to_self_publish = HashSet::with_capacity(ops.len()); | |||
| for op in &ops { | |||
| if network.authority_for_hash(op.0.dht_basis().clone()).await? { | |||
There was a problem hiding this comment.
I think it might be worth the complexity to join_all these so they can run in parallel instead of serially.
As it is, the cpu will have to switch off between the network ghost_actor task and this one, where, if they are all sent at once, ghost_actor internally does a ready_chunks so the cpu can stay on that code until complete.
There was a problem hiding this comment.
Maybe it makes more sense to just make authority for has take a vec? So we can batch the call?
neonphog
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.