Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid zip files panic #111

Closed
matthme opened this issue Dec 23, 2022 · 0 comments
Closed

Invalid zip files panic #111

matthme opened this issue Dec 23, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@matthme
Copy link
Collaborator

matthme commented Dec 23, 2022 •
edited

Describe the bug
If a .webhapp contains an invalid zip file as ui assets, the installation panics and there is no error message. Instead the installation loading wheel just wheels into infinity.

This line is the culprit. The unwrap() needs to be replaced with a meaningful error handling.

To Reproduce
Steps to reproduce the behavior:

  1. Create a happ release on the DevHub with a GUI release with an invalid ui.zip.
  2. Try to install this app from the App Library

Expected behavior
I expect to get a meaningful error instead of a silent panic.
@matthme matthme added the bug Something isn't working label Dec 23, 2022
matthme added a commit that referenced this issue Mar 7, 2023
@matthme
properly handling unzipping errors, fixes #111
9a3cbe8
@matthme matthme closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthme