fix: improve ts codegen and formatting for ts/tsx files #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c12i
added
the
ShouldBackport/0.3
c12i
added a commit
to c12i/scaffolding
that referenced
this pull request
Jun 19, 2024
* refactor: replace tempalte derived types.ts files with rust-geneted ones * fix typo * add programatic formatting * fix incorrectly named variable in tests * ignore formatting EntryTypes * fix invalid enum types * fix: improve code formatting in ts/tsx files * fix clippy warning * fix failing codgegen tests * rename tests module
c12i
removed
the
ShouldBackport/0.3
c12i
added a commit
that referenced
this pull request
Jun 19, 2024
* bump versions * feat: Add react template (#295) * WIP * update ui module * add react to matched ui framework strings * hbsify templates * add base react components * react collection * react detail component * react create component * react edit template * react entry type for linked from component * field types * react link type components * fix field types * template swoop; fix issues * add missing imports, strip out eslint * fix images * refactor holochain provider * fix entry-type templates * fix link-type templates * correctly name field type widgets * add forum example * fix holochain context * check for links lengths before setting state * fix text field * styling improvments * extend base styles * improve example styling * fix mismatched components * remove ui readme * fix templates * fix imports * update elements and imports * type app signal callback * test with react template in ci * update styling * fix global styles * rename and move client context * make client context compatible with holo * fix indentation in templates * update client context template * fix entry-types for linked from component props * update detail components * add default field types * fix example app.tsx * fix vec detail render * fix vec edit render * fix timestamp * fix client context not updating loading state * fix vec input * fix vec input setters in edit components * Update templates/react/field-types/u32/NumberInput/edit/render.hbs Co-authored-by: Paul d'Aoust <amillionlobsters@gmail.com> * Update templates/react/field-types/Timestamp/DateTimePicker/edit/render.hbs Co-authored-by: Paul d'Aoust <amillionlobsters@gmail.com> * Update templates/react/field-types/Timestamp/DateTimePicker/edit/render.hbs Co-authored-by: Paul d'Aoust <amillionlobsters@gmail.com> * set default and initial values for boolean inputs to false * ensure previous zip file is deleted * fix templates --------- Co-authored-by: Paul d'Aoust <amillionlobsters@gmail.com> * fix: holochain client error handling (#298) * fix: holochain client error handling * fix: typescript failures in lit template * fix: holo web sdk version not part of ScaffoldWebAppData (#302) * fix: Add missing web-sdk-version to template data * rename holo web sdk template field * fix: Include react in testable templates; bump versions (#310) * fix: add react to testable templates * bump crate version; nix flake update * bump versions * nix flake update * fix: improve ts codegen and formatting for ts/tsx files (#311) * refactor: replace tempalte derived types.ts files with rust-geneted ones * fix typo * add programatic formatting * fix incorrectly named variable in tests * ignore formatting EntryTypes * fix invalid enum types * fix: improve code formatting in ts/tsx files * fix clippy warning * fix failing codgegen tests * rename tests module * update holonix version --------- Co-authored-by: Paul d'Aoust <amillionlobsters@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves TypeScript and tsx code generation and formatting. It includes several key changes and fixes:
types.tsfiles with Rust-generated ones.Closes #309