refactor all the data things #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sand-state and be 'linked data'-able)
added 12 commits
April 8, 2015 19:26
|
woooo, i've finally reached feature parity with the current app after these changes! 🎈 @simontegg would be nice to have a small bit of code review, at least to make sure this branch runs for you and that you support us merging it in to master and deploying to production. the code isn't ideal, but it's enough for us to keep on moving forward. cheers. |
|
Looks great. |
Closed
This was referenced Apr 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting with the data structure changes described in openvocab/holodex#1, i rewrote most of the data-related code, a few times, plus i threw away most of the api code. it's not perfect, but it does what we need for now, and most importantly i've learned heaps about what we actually want for when i rewrite it some more.
close holodex/holodex#13.
close #48.
note: this PR is not ready to merge, but is getting close. i didn't intend for it to be such a large PR, but oh well, better luck next time.