Moving opensky #26
Merged
Moving opensky #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsignell
commented
May 29, 2019
jsignell
commented
- Put in dir with matching name
- Added anaconda-project
- Added env info and data downloads
- Ran locally
- Moved data preparation scripts into own files
- Added test data
- Added opensky to travis.yml
jbednar
reviewed
May 29, 2019
| @@ -33,6 +33,8 @@ jobs: | |||
| if: (commit_message !~ /^.*(only:).*$/) OR (commit_message =~ concat(^.*,env(DIR),.*$)) | |||
| - env: DIR=nyc_taxi | |||
| if: (commit_message !~ /^.*(only:).*$/) OR (commit_message =~ concat(^.*,env(DIR),.*$)) | |||
| - env: DIR=opensky | |||
There was a problem hiding this comment.
It sure would be nice if .travis.yml didn't have to hard-code the name of each project, so that projects can be added and deleted without editing this shared file.
jbednar
reviewed
May 29, 2019
| @@ -0,0 +1,50 @@ | |||
| # To reproduce: install 'anaconda-project', then 'anaconda-project run' | |||
| name: opensky | |||
| description: Datashading spatially-optimized OpenSky flight trajectories | |||
There was a problem hiding this comment.
Does the spatial optimization even have any meaning for this case (line segments), as a given starting point won't necessarily have a destination point in the same partition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.