Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are or will be these colormaps merged back to matplotlib? #13

Closed
KOLANICH opened this issue Aug 4, 2018 · 4 comments
Closed

Are or will be these colormaps merged back to matplotlib? #13

KOLANICH opened this issue Aug 4, 2018 · 4 comments

Comments

@KOLANICH
Copy link

KOLANICH commented Aug 4, 2018

No description provided.

@bryevdv
Copy link
Member

bryevdv commented Aug 4, 2018

It's entirely up to the Matplotlib developers when or if or how these would be included in MPL. However given that several projects use these colormaps, not just MPL, in my own opinion it would be much more sensible for MPL to add colorcet as a runtime dependency, rather than duplicatively vendoring literal code.

@KOLANICH
Copy link
Author

KOLANICH commented Aug 4, 2018

Every 3rd-party dependency is a risk. It may make more sense to put the code into mpl and add a dummy package importing the stuff from mpl (and displaying a warning) just for compatibility.

@bryevdv
Copy link
Member

bryevdv commented Aug 4, 2018

I can state fairly confidently that the owners of this package wish it to remain separate. MPL devs could take it upon themselves to vendor the code if they choose. I note that none of the people in this project are MPL devs, so this is not really a useful place to take that question up.

@KOLANICH
Copy link
Author

KOLANICH commented Aug 4, 2018

I can state fairly confidently that the owners of this package wish it to remain separate.

That's what I wanted to know, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants