You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There actually look to be even more in colorcet.m, I guess that's the ultimate canonical source?
I'm a bit unsure how to integrate these changes into CET_to_py.py, especially the D01-D09 and L01-09 stuff. Or maybe this project keeps the original CSV names?
The text was updated successfully, but these errors were encountered:
Yes, it would be great to get those new maps. Looks like the names have again changed upstream, and the values have also been truncated to fewer (not more) significant digits, which probably doesn't matter but could conceivably change a color. I'd rather not change any of the existing maps at all, so I'd want to get only the new ones. I've also kept the original naming style for continuity.
I think the steps involved in such a PR would be:
Unpack the new CETperceptual_csv_0_1.zip into assets/CETperceptual_csv_0_1_v3.
If any of the ones in colorcet.m are useful (and not just e.g. stray obsolete versions), make CSVs for them and put them in e.g. assets/colorcet_m_to_csv
Edit assets/CET_to_py.py:
Add the new directory(s) to paths
Add support for v3 (and colorcet_m) following what's done already for v2 (though it's fairly complicated at first glance!)
Add mapping info to mapping, with long names for the short filenames from v3 (not sure where that mapping came from; maybe it's on Peter's website?)
Add aliases where appropriate (e.g. wrkb, ymcgy, gouldian, rainbowbr)
Run CET_to_py.py to generate an updated colorcet/__init__.py.
Check the generated colorcet/__init__.py to make sure it didn't mess up any of the existing colormaps and defines the new ones properly, and doesn't somehow get extra copies of all the v1 and v2 maps that are duplicated in v3.
Make a PR with the new CSVs and updated colorcet/__init__.py.
Seems like somehow it didn't need to be this complicated, but I don't see how to simplify it.
Changes in upstream CSVs:
New
Changed
There actually look to be even more in colorcet.m, I guess that's the ultimate canonical source?
I'm a bit unsure how to integrate these changes into CET_to_py.py, especially the D01-D09 and L01-09 stuff. Or maybe this project keeps the original CSV names?
The text was updated successfully, but these errors were encountered: