Make crs better at handling EPSG #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like 0.9.3 is getting queued up for release so not sure if there is a way to sneak this in @maximlt 😸 |
jsignell
commented
Apr 23, 2024
| except Exception as e: | ||
| errors.append(e) | ||
| if isinstance(crs, (str, pyproj.Proj)): # proj4/wkt strings | ||
|
|
||
| if isinstance(crs, (str, int)): |
There was a problem hiding this comment.
This idea is that this is purely additive. It should have no impact on code paths that were already working.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1330 +/- ##
==========================================
+ Coverage 87.36% 87.39% +0.03%
==========================================
Files 50 50
Lines 7471 7489 +18
==========================================
+ Hits 6527 6545 +18
Misses 944 944 ☔ View full report in Codecov by Sentry. |
|
Nice! I'll review and include it in the next release. |
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1329 and adds a test to try to prevent regression in the future.