fix: reject already existing usernames #443 #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use ErrorDisplay component
Meierschlumpf
changed the title
Meierschlumpf
previously requested changes
May 10, 2024
apps/nextjs/src/app/[locale]/manage/users/[userId]/_components/profile.accordion.tsx
Outdated
Show resolved
Hide resolved
ajnart
commented
May 10, 2024
apps/nextjs/src/app/[locale]/manage/users/[userId]/_components/profile.accordion.tsx
Outdated
Show resolved
Hide resolved
manuel-rw
previously approved these changes
May 11, 2024
|
@manuel-rw @Meierschlumpf we fix conflicts then merge ? |
|
when my part is okay then yes |
Meierschlumpf
approved these changes
May 19, 2024
|
Please use squash commits instead of merge commits for features 😉 |
I was able to restrict pull requests to dev to only allow squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homarr
Motivation
Closes #443
Changes
namealready exists. If that's the case then an error is thrown. ( 781247d )