Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose "lights" property to Group and Scene #6

Closed
MizterB opened this issue May 8, 2018 · 5 comments
Closed

Expose "lights" property to Group and Scene #6

MizterB opened this issue May 8, 2018 · 5 comments

Comments

@MizterB
Copy link
Contributor

MizterB commented May 8, 2018

Can you please include the lights property in the group class? Understanding which lights are in a group will be required to correctly map groups to scenes. This would allow us to address the following issue in HomeAssistant, where the Hue component is not correctly handling duplicate scene names.

home-assistant/core#13685 (comment)

@Mariusthvdb
Copy link

Mariusthvdb commented May 8, 2018

cant stress my support for this request enough.
This seems not only to be the cause for the hue.hue_activate_scene issue (which needs the groups), but might very well be the cause for other Hue issues started after the same update (now 0.68.1) from 0.65 which worked very fine indeed.

reference here: https://community.home-assistant.io/t/update-to-68-0-1-how-to-debug-config-error-hassio-hue-setup/52224

ever appearing error in the log:

snippet:


018-05-02 23:44:19 ERROR (MainThread) [homeassistant.components.light.hue] Unable to reach bridge 192.168.1.212
2018-05-02 23:44:19 WARNING (MainThread) [homeassistant.setup] Setup of hassio is taking over 10 seconds.
2018-05-02 23:44:19 ERROR (MainThread) [homeassistant.core] Timer got out of sync. Resetting
2018-05-02 23:44:20 ERROR (MainThread) [homeassistant.components.hassio.handler] Timeout on /supervisor/ping request

among the many timing issues and Hassio not being able to load, and the lights switching between being recognized and unavailable state in the Hassio setup.

maybe this is because of home-assistant/core#13109, and apparently a feature rather than a bug, but the thing is the Hub isn't unavailable at all.. My system sees it on several ways. The Hue app, the router, Home-assistant rest sensor, etc etc. All showing the Hub being online and available, even the lights and all sensors. Its just the new Ha implementation that says otherwise...

Hope this gets fixed soon, let me know where i could be of any help.

@MizterB MizterB changed the title Add "lights" property to group Expose "lights" property to Group and Scene May 15, 2018
@MizterB
Copy link
Contributor Author

MizterB commented May 15, 2018

To resolve the HA issue, the light property also needs to be exposed in a Scene. Pull request addresses both Scene and Group needs.

balloob pushed a commit that referenced this issue May 25, 2018
* Add the "lights" property from the groups API, per #6

* Exposing all available properties of the Scenes object
@balloob
Copy link
Collaborator

balloob commented May 25, 2018

Fixed in #8 and released as 1.5.0

@balloob balloob closed this as completed May 25, 2018
@MizterB
Copy link
Contributor Author

MizterB commented May 26, 2018

Thank you! Will update the HA functionality once 1.5.0 is on pypi.

@balloob
Copy link
Collaborator

balloob commented May 26, 2018

Published. Didn't see PyPi blocked last release because README was inproper format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants