Switch to limit per host on tcp connector #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jan 31, 2022
aiohue/v2/__init__.py
Outdated
| @@ -48,7 +45,16 @@ def __init__( | |||
| self._app_key = app_key | |||
| self._websession = websession | |||
| self._websession_provided = websession is not None | |||
|
|
|||
| if websession and ( | |||
There was a problem hiding this comment.
I suggest we just always make our own.
balloob
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Signify support it is very important that we have a guard in place to make sure that there are no more than 3 concurrent requests to the bridge. Putting this guard on the TCP Connector for aiohttp solves all 503 errors.
Sending 100 requests now completes in 2,2 seconds without a single 503 error ;-)
I've put a small detection in the code if a TCP connector is given without this limit (e.g. Home Assistant as a temporary measure until we can adjust the global logic in HA to respect this host limit.