Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aggregated grouped_lights commands #126

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Conversation

marcelveldt
Copy link
Collaborator

No more need to send light commands to each individual light of a group as Signify added support to send aggregated commands on the API.

"""
"""Set supported feature(s) to grouped_light resource."""
# Sending (color) commands to grouped_light was added in Bridge version 1.50.1950111030
self._bridge.config.require_version("1.50.1950111030")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this a decorator ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking in that direction too but we require the config object so we'll have to fuss with a lookup from the class instance... Maybe for later ?

@balloob balloob merged commit 9660cfb into master Mar 22, 2022
@balloob balloob deleted the group-commands branch March 22, 2022 21:51
@jdiegmueller
Copy link

No more need to send light commands to each individual light of a group as Signify added support to send aggregated commands on the API.

I am still seeing the one-at-a-time behavior with HomeAssistant 2022.3.7/aiohue 4.4.1. Is this expected?

@marcelveldt
Copy link
Collaborator Author

No more need to send light commands to each individual light of a group as Signify added support to send aggregated commands on the API.

I am still seeing the one-at-a-time behavior with HomeAssistant 2022.3.7/aiohue 4.4.1. Is this expected?

Yes, you'll have to wait for a new version (2022.4) of HA as this is a new feature.

@jdiegmueller
Copy link

Yes, you'll have to wait for a new version (2022.4) of HA as this is a new feature.

Ah, I see; thank you. I thought the aiohue 4.4.1 bump in 2022.3.7 was all that was necessary. Will sit tight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants