Add monitor configuration type #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
reviewed
Aug 2, 2022
| @@ -58,6 +58,9 @@ class EntertainmentConfigurationType(Enum): | |||
| MUSIC = "music" # Channels are organized for music synchronization | |||
| THREEDEESPACE = "3dspace" # Channels are organized to provide 3d spacial effects | |||
| OTHER = "other" # General use case " | |||
| MONITOR = ( | |||
| "monitor" # Channels are organized around content from one or several monitors | |||
There was a problem hiding this comment.
can you either shorten the comment or place it above the definition ?
thanks
|
Shortened the comment since putting it above the definition looked a bit weird |
|
Thanks! |
|
Is there something needed from my side to get this into a new aiohue release so it can get into Home Assistant? |
|
I'll publish a new version within a few days. Let me quickly check if there are any other things that need fixing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"monitor" is a new configuration type for Entertainment Configurations and can be created through the latest Hue App.
Description is from the Hue API website.
Fixes #140
Checked it by running the example vor v2 which gave the message that "monitor" was not supported, after updating the same example ran without the message