Ensure black formatting stability in workflow #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use psf/black@latest and set stability version to avoid workflow breaking as per https://black.readthedocs.io/en/stable/integrations/github_actions.html#usage
frenck
previously requested changes
Mar 21, 2024
|
In the future I would prefer to replace black with ruff |
agree, IMHO it would also be great to use pre-commit + pre-commit-action to pin and orchestrate the linting + tests to make contributing easier by running pre-commit locally. Also maybe allowing lint workflow to be invoked without approval would reduce PR noise for you guys. |
This was referenced Mar 21, 2024
Merged
|
@frenck fixed the pinning, please merge and i will rebase other PR |
klaasnicolaas
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed my PRs are failing black even though i've made no changes. I think using recommendedpsf/black@stableaction version and stabilityversionwill fix thisI noticed my PRs are failing black even though i've made no changes. Using
psf/black@24.3.0action version and stabilityversion: "~= 22.0"will fix thisSeems that using
psf/black@xx.yy.zzaction does not guaranteeblack==xx.yy.zzformat rules are used as one would expect.psf/black@23.3.0and add stabilityversion: "~= 22.0"to prevent workflow from failing due to upstream changes in black format