This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
MDNSDiscoverable: Set ATTR_MAC_ADDRESS if available. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mDNS properties include a "mac" key, set top-level ATTR_MAC_ADDRESS info property for consistency. This property for example is available for Yeelight lights.
|
This is another step towards having a consistent library interface (set of returned info fields), and addresses issue mentioned in #141 (comment) . Turned out the fix needs to be applied on MDNSDiscoverable level, so might help other devices too. |
balloob
approved these changes
Aug 29, 2017
|
Awesome, thanks 🐬 |
|
I'll aim to do a new release of netdisco after the Xiaomi PR is in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If mDNS properties include a "mac" key, set top-level ATTR_MAC_ADDRESS
info property for consistency.
This property for example is available for Yeelight lights.