be more strict on songpal filtering

[rytilahti]

Check for the existence of videoScreen service, which should be solely available on televisions.

Fixes https://community.home-assistant.io/t/platform-songpal-not-ready-yet-log-entry-linked-to-braviatv/93586 and potentially other similar misdetection issues.

[balloob]

Instead of filtering things out, we should only include things that match our spec. If SongPal cannot be identified, we shouldn't just include ALL devices that implement this API and filter them out.

[rytilahti]

You are right, I made the filtering saner by checking for an existence of an interface exposed by bravias but not by the sound devices, i.e. filtering out devices which expose an interface the backend library does not support.

The problem in whitelisting songpal devices is that both types of devices implement the very same set of basic interfaces (guide for API inspection, audio for audio controls, avContent for playback/content controls and system for changing the settings of the device).

[balloob]

Isn't there nothing in the XML that uniquely identifies it ? Like manufacturer etc?

[rytilahti]

So these are all Sony devices, the "songpal" API is really their generic, extensible API which they are using in different product series (from cameras to televisions to home audio). The Bravias simply expose more interfaces than the audio-only devices, and that's what this change uses to filter them out.

On potential identifiers in the XML, to my experience the friendlyName contains sometimes the name of the product series (at least some bravias do), but no, there is no definite identification of the device type in the XML. It is possible to query the device type over the API, but that'd require initializing the platform and then do the check on homeassistant's end.

[balloob]

Alrighty.