Bump pylint to 2.6.0 (#454)

* Bump pylint to 2.6.0 * Tweak pylint's path * Accept pylint's advise * Try to make pylint less confused
home-assistant-libs · Jan 28, 2021 · c2ee33e · c2ee33e
1 parent 992bdb3
commit c2ee33e
Show file tree

Hide file tree

Showing 12 changed files with 19 additions and 21 deletions.
diff --git a/__init__.py b/__init__.py
diff --git a/pychromecast/controllers/bubbleupnp.py b/pychromecast/controllers/bubbleupnp.py
@@ -11,7 +11,7 @@ class BubbleUPNPController(MediaController):
 
     # pylint: disable=useless-super-delegation
     def __init__(self):
-        super(BubbleUPNPController, self).__init__()
+        super().__init__()
         self.app_id = APP_BUBBLEUPNP
         self.supporting_app_id = APP_BUBBLEUPNP
 

diff --git a/pychromecast/controllers/dashcast.py b/pychromecast/controllers/dashcast.py
@@ -15,7 +15,7 @@ class DashCastController(BaseController):
     # The pylint rule useless-super-delegation doesn't realize
     # we are setting default values here.
     def __init__(self, appNamespace=APP_NAMESPACE, appId=APP_DASHCAST):
-        super(DashCastController, self).__init__(appNamespace, appId)
+        super().__init__(appNamespace, appId)
 
     # pylint: enable=useless-super-delegation
 

diff --git a/pychromecast/controllers/media.py b/pychromecast/controllers/media.py
@@ -324,7 +324,7 @@ class MediaController(BaseController):
     """ Controller to interact with Google media namespace. """
 
     def __init__(self):
-        super(MediaController, self).__init__("urn:x-cast:com.google.cast.media")
+        super().__init__("urn:x-cast:com.google.cast.media")
 
         self.media_session_id = 0
         self.status = MediaStatus()
@@ -650,6 +650,6 @@ def _send_start_play_media(
 
     def tear_down(self):
         """ Called when controller is destroyed. """
-        super(MediaController, self).tear_down()
+        super().tear_down()
 
         self._status_listeners[:] = []
diff --git a/pychromecast/controllers/multizone.py b/pychromecast/controllers/multizone.py
@@ -193,9 +193,7 @@ def __init__(self, uuid):
         self._members = {}
         self._status_listeners = []
         self._uuid = str(uuid)
-        super(MultizoneController, self).__init__(
-            MULTIZONE_NAMESPACE, target_platform=True
-        )
+        super().__init__(MULTIZONE_NAMESPACE, target_platform=True)
 
     def _add_member(self, uuid, name):
         if uuid not in self._members:
@@ -303,6 +301,6 @@ def receive_message(
 
     def tear_down(self):
         """ Called when controller is destroyed. """
-        super(MultizoneController, self).tear_down()
+        super().tear_down()
 
         self._status_listeners[:] = []
diff --git a/pychromecast/controllers/plex.py b/pychromecast/controllers/plex.py
@@ -175,7 +175,7 @@ class PlexController(BaseController):
     """ Controller to interact with Plex namespace. """
 
     def __init__(self):
-        super(PlexController, self).__init__("urn:x-cast:plex", "9AC194DC")
+        super().__init__("urn:x-cast:plex", "9AC194DC")
         self.app_id = "9AC194DC"
         self.namespace = "urn:x-cast:plex"
         self.request_id = 0
@@ -468,7 +468,7 @@ class PlexApiController(PlexController):
     """A controller that can use PlexAPI."""
 
     def __init__(self, pms):
-        super(PlexApiController, self).__init__()
+        super().__init__()
         self.pms = pms
 
     def _get_current_media(self):

diff --git a/pychromecast/controllers/spotify.py b/pychromecast/controllers/spotify.py
@@ -24,7 +24,7 @@ class SpotifyController(BaseController):
     # The pylint rule useless-super-delegation doesn't realize
     # we are setting default values here.
     def __init__(self, access_token=None, expires=None):
-        super(SpotifyController, self).__init__(APP_NAMESPACE, APP_SPOTIFY)
+        super().__init__(APP_NAMESPACE, APP_SPOTIFY)
 
         self.logger = logging.getLogger(__name__)
         self.session_started = False

diff --git a/pychromecast/controllers/supla.py b/pychromecast/controllers/supla.py
@@ -17,7 +17,7 @@ class SuplaController(BaseController):
     # The pylint rule useless-super-delegation doesn't realize
     # we are setting default values here.
     def __init__(self):
-        super(SuplaController, self).__init__(APP_NAMESPACE, APP_SUPLA)
+        super().__init__(APP_NAMESPACE, APP_SUPLA)
 
         self.logger = logging.getLogger(__name__)
 

diff --git a/pychromecast/controllers/yleareena.py b/pychromecast/controllers/yleareena.py
@@ -11,7 +11,7 @@ class YleAreenaController(MediaController):
 
     # pylint: disable=useless-super-delegation
     def __init__(self):
-        super(YleAreenaController, self).__init__()
+        super().__init__()
         self.app_id = APP_YLEAREENA
         self.supporting_app_id = APP_YLEAREENA
 

diff --git a/pychromecast/controllers/youtube.py b/pychromecast/controllers/youtube.py
@@ -20,7 +20,7 @@ class YouTubeController(BaseController):
     """ Controller to interact with Youtube."""
 
     def __init__(self):
-        super(YouTubeController, self).__init__(YOUTUBE_NAMESPACE, APP_YOUTUBE)
+        super().__init__(YOUTUBE_NAMESPACE, APP_YOUTUBE)
         self.status_update_event = threading.Event()
         self._screen_id = None
         self._session = None

diff --git a/pychromecast/socket_client.py b/pychromecast/socket_client.py
@@ -223,7 +223,7 @@ def __init__(self, host, port=None, cast_type=CAST_TYPE_CHROMECAST, **kwargs):
         services = kwargs.pop("services", None)
         zconf = kwargs.pop("zconf", None)
 
-        super(SocketClient, self).__init__()
+        super().__init__()
 
         self.daemon = True
 
@@ -424,7 +424,7 @@ def mdns_backoff(service, retry):
                             self.port,
                             err,
                         )
-                        raise ChromecastConnectionError("Failed to connect")
+                        raise ChromecastConnectionError("Failed to connect") from err
 
                     self._report_connection_status(
                         ConnectionStatus(
@@ -1042,7 +1042,7 @@ class ConnectionController(BaseController):
     """ Controller to respond to connection messages. """
 
     def __init__(self):
-        super(ConnectionController, self).__init__(NS_CONNECTION)
+        super().__init__(NS_CONNECTION)
 
     def receive_message(self, message, data: dict):
         """
@@ -1069,7 +1069,7 @@ class HeartbeatController(BaseController):
     """ Controller to respond to heartbeat messages. """
 
     def __init__(self):
-        super(HeartbeatController, self).__init__(NS_HEARTBEAT, target_platform=True)
+        super().__init__(NS_HEARTBEAT, target_platform=True)
         self.last_ping = 0
         self.last_pong = time.time()
 
@@ -1134,7 +1134,7 @@ class ReceiverController(BaseController):
     """
 
     def __init__(self, cast_type=CAST_TYPE_CHROMECAST):
-        super(ReceiverController, self).__init__(NS_RECEIVER, target_platform=True)
+        super().__init__(NS_RECEIVER, target_platform=True)
 
         self.status = None
         self.launch_failure = None
@@ -1343,7 +1343,7 @@ def _process_launch_error(self, data):
 
     def tear_down(self):
         """ Called when controller is destroyed. """
-        super(ReceiverController, self).tear_down()
+        super().tear_down()
 
         self.status = None
         self.launch_failure = None

diff --git a/requirements-test.txt b/requirements-test.txt
@@ -1,3 +1,3 @@
 flake8==3.8.4
-pylint==2.4.4
+pylint==2.6.0
 black==20.8b1