Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unintended 'async' from listener interfaces #453

Merged
merged 1 commit into from
Jan 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pychromecast/controllers/media.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ class MediaStatusListener(abc.ABC):
"""Listener for receiving media status events."""

@abc.abstractmethod
async def new_media_status(self, status: MediaStatus):
def new_media_status(self, status: MediaStatus):
"""Updated media status."""


Expand Down
18 changes: 7 additions & 11 deletions pychromecast/controllers/multizone.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,21 +97,19 @@ class MultiZoneManagerListener(abc.ABC):
"""Listener for receiving audio group events for a cast device."""

@abc.abstractmethod
async def added_to_multizone(self, group_uuid: str):
def added_to_multizone(self, group_uuid: str):
"""The cast has been added to group identified by group_uuid."""

@abc.abstractmethod
async def removed_from_multizone(self, group_uuid: str):
def removed_from_multizone(self, group_uuid: str):
"""The cast has been removed from group identified by group_uuid."""

@abc.abstractmethod
async def multizone_new_media_status(
self, group_uuid: str, media_status: MediaStatus
):
def multizone_new_media_status(self, group_uuid: str, media_status: MediaStatus):
"""The group identified by group_uuid, of which the cast is a member, has new media status."""

@abc.abstractmethod
async def multizone_new_cast_status(self, group_uuid: str, cast_status: CastStatus):
def multizone_new_cast_status(self, group_uuid: str, cast_status: CastStatus):
"""The group identified by group_uuid, of which the cast is a member, has new status."""


Expand Down Expand Up @@ -176,17 +174,15 @@ class MultiZoneControllerListener(abc.ABC):
"""Listener for receiving audio group events."""

@abc.abstractmethod
async def multizone_member_added(self, group_uuid: str):
def multizone_member_added(self, group_uuid: str):
"""The cast has been added to group identified by group_uuid."""

@abc.abstractmethod
async def multizone_member_removed(self, group_uuid: str):
def multizone_member_removed(self, group_uuid: str):
"""The cast has been removed from group identified by group_uuid."""

@abc.abstractmethod
async def multizone_status_received(
self, group_uuid: str, media_status: MediaStatus
):
def multizone_status_received(self, group_uuid: str, media_status: MediaStatus):
"""The group identified by group_uuid, of which the cast is a member, has new status."""


Expand Down
6 changes: 3 additions & 3 deletions pychromecast/socket_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,23 +167,23 @@ class CastStatusListener(abc.ABC):
"""Listener for receiving cast status events."""

@abc.abstractmethod
async def new_cast_status(self, status: CastStatus):
def new_cast_status(self, status: CastStatus):
"""Updated cast status."""


class ConnectionStatusListener(abc.ABC):
"""Listener for receiving connection status events."""

@abc.abstractmethod
async def new_connection_status(self, status: ConnectionStatus):
def new_connection_status(self, status: ConnectionStatus):
"""Updated connection status."""


class LaunchErrorListener(abc.ABC):
"""Listener for receiving launch error events."""

@abc.abstractmethod
async def new_launch_error(self, status: LaunchFailure):
def new_launch_error(self, status: LaunchFailure):
"""Launch error."""


Expand Down