Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle bad UUIDs from third-party Chromecasts #486

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Handle bad UUIDs from third-party Chromecasts #486

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dab7645
Handle bad UUIDs from third-party Chromecasts
Apr 5, 2021
633efc2
remove e as it's unused
Apr 5, 2021
48fe900
Update pychromecast/discovery.py
emontnemery Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 12 additions & 1 deletion pychromecast/discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,18 @@ def get_value(key):
"_add_update_service failed to get uuid for %s, %s", typ, name
)
return
uuid = UUID(uuid)

# Handle incorrect UUIDs from third-party Chromecast emulators
emontnemery marked this conversation as resolved.
Show resolved Hide resolved
try:
uuid = UUID(uuid)
except ValueError:
_LOGGER.debug(
"_add_update_service failed due to bad uuid for %s, %s, model %s",
typ,
name,
model_name,
)
return

service_info = ServiceInfo(SERVICE_TYPE_MDNS, name)

Expand Down