Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #581

Merged
merged 2 commits into from Feb 14, 2024
Merged

Update README.rst #581

merged 2 commits into from Feb 14, 2024

Conversation

strunker
Copy link
Contributor

So I had some pretty big blockers using the new library and discovery methods. I also finally realized what kind of firewall rules need to be created in order for zeroconf discovery to work properly. On windows I created two rules. one inbound, one outbound, for ports 1900,5353 and allowed them through the firewall. Afterwards I was able to do proper chromecast discovery without needing to disable my firewall. I also added some additional examples on how to discover numerous devices by friendly name, and I think a super important thing to include is the param discovery_timeout. I was getting many more devices using get_chromecasts() that I was not getting with get_listed_chromecasts() so I examined the difference and realized the timing is much more aggressive by default on get_listed_chromecasts(), the param helps alleviate that, and accounts for networks\devices that are slower to respond.

So I had some pretty big blockers using the new library and discovery methods. I also finally realized what kind of firewall rules need to be created in order for zeroconf discovery to work properly. On windows I created two rules. one inbound, one outbound, for ports 1900,5353 and allowed them through the firewall. Afterwards I was able to do proper chromecast discovery without needing to disable my firewall. I also added some additional examples on how to discover numerous devices by friendly name, and I think a super important thing to include is the param discovery_timeout. I was getting many more devices using get_chromecasts() that I was not getting with get_listed_chromecasts() so I examined the difference and realized the timing is much more aggressive by default on get_listed_chromecasts(), the param helps alleviate that, and accounts for networks\devices that are slower to respond.
@strunker
Copy link
Contributor Author

Anyone out there who can review this? This really should be merged in the readme document doesnt really provide everything you need to know to be successful in setting things up.

Copy link
Collaborator

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pychromecast does not rely on SSDP for discovery, so we don't need to mention that. If you don't agree @strunker, please open another PR which motivates why SSDP is required.

README.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @strunker 👍

I'm sorry about the very long delay for reviewing this.

@emontnemery emontnemery merged commit f1975e8 into home-assistant-libs:master Feb 14, 2024
1 check passed
@strunker
Copy link
Contributor Author

Thanks @emontnemery all good on the delay. Hope these additions help others who run on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants