Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I had some pretty big blockers using the new library and discovery methods. I also finally realized what kind of firewall rules need to be created in order for zeroconf discovery to work properly. On windows I created two rules. one inbound, one outbound, for ports 1900,5353 and allowed them through the firewall. Afterwards I was able to do proper chromecast discovery without needing to disable my firewall. I also added some additional examples on how to discover numerous devices by friendly name, and I think a super important thing to include is the param discovery_timeout. I was getting many more devices using get_chromecasts() that I was not getting with get_listed_chromecasts() so I examined the difference and realized the timing is much more aggressive by default on get_listed_chromecasts(), the param helps alleviate that, and accounts for networks\devices that are slower to respond.