Add type annotations to controllers/receiver.py #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
Jan 18, 2024
| @@ -15,8 +15,11 @@ | |||
| REQUEST_TIMEOUT, | |||
| SESSION_ID, | |||
| ) | |||
| from ..generated.cast_channel_pb2 import ( # pylint: disable=no-name-in-module | |||
There was a problem hiding this comment.
Will this always be the case for generated modules that pylint doesn't understand them?
There was a problem hiding this comment.
It seems like it, yes.
Pylint actually very recently gained support for pyi stub files pylint-dev/pylint#4987, but I guess the support is still rough around the edges.
For example, this comment mentions something very similar: pylint-dev/pylint#4987 (comment)
I think this is why it doesn't work: pylint-dev/pylint#9185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.