Add type annotations to examples #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
force-pushed
the
type_annotate_examples
branch
from
89b700c
to
887c01d
Compare
emontnemery
commented
Feb 7, 2024
Comment on lines
+23
to
25
| ^examples/plex_multi_example\.py$ | ||
| | ^pychromecast/generated/ # The protobuf autogenerated files are not annotated | ||
| | ^pychromecast/controllers/plex\.py$ |
There was a problem hiding this comment.
In a separate PR, the plex controller and the example will be type annotated
MartinHjelmare
approved these changes
Feb 7, 2024
| print("[", time.ctime(), " - ", self.name, "] status media change:") | ||
| print(status) | ||
|
|
||
| def load_media_failed(self, item, error_code): | ||
| def load_media_failed(self, item: int, error_code: int) -> None: |
There was a problem hiding this comment.
What does the item represent?
There was a problem hiding this comment.
It's to identify which item of a queue failed to play, Google calls it itemId.
We should update the docstring for MediaStatusListener and maybe also rename the parameter to queue_item or queue_item_id to make it clearer what it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.