Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dual-stack support #861

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions pychromecast/socket_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,16 @@ def mdns_backoff(
self.host,
self.port,
)
self.socket.connect((self.host, self.port))

mapped_host = socket.getaddrinfo(
self.host,
self.port,
self.socket.family,
socket.SOCK_STREAM,
flags=(socket.AI_ADDRCONFIG | socket.AI_V4MAPPED),
)[0][4]

self.socket.connect(mapped_host)
context = ssl.SSLContext(ssl.PROTOCOL_TLS_CLIENT)
context.check_hostname = False
context.verify_mode = ssl.CERT_NONE
Expand Down Expand Up @@ -1133,7 +1142,14 @@ def new_socket() -> socket.socket:
Try to set SO_REUSEPORT for BSD-flavored systems if it's an option.
Catches errors if not.
"""
new_sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
try:
new_sock = socket.socket(socket.AF_INET6, socket.SOCK_STREAM)
# ensuring dual-stack
new_sock.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 0)
DerEnderKeks marked this conversation as resolved.
Show resolved Hide resolved
except OSError:
# falling back to IPv4 on systems without IPv6
new_sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
DerEnderKeks marked this conversation as resolved.
Show resolved Hide resolved

new_sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)

try:
Expand Down