Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify datamodel #213

Merged
merged 42 commits into from Feb 22, 2023
Merged

Simplify datamodel #213

merged 42 commits into from Feb 22, 2023

Conversation

marcelveldt
Copy link
Contributor

@marcelveldt marcelveldt commented Feb 21, 2023 •
edited

  • Only store bare minimum of a node in the server (just the attributes raw value)
  • Construct MatterNode in the client
  • Construct DeviceType(instance) in the client
  • Move Interview Logic
  • Bump schema version

BREAKING CHANGE

Marked as draft because this depends on updated wheels

MartinHjelmare
MartinHjelmare reviewed Feb 21, 2023
View reviewed changes
matter_server/client/client.py Outdated Show resolved Hide resolved
matter_server/client/client.py Outdated Show resolved Hide resolved
matter_server/client/models/node.py Outdated Show resolved Hide resolved
matter_server/client/models/node.py Outdated Show resolved Hide resolved
matter_server/client/models/node.py Outdated Show resolved Hide resolved
matter_server/client/models/node.py Outdated Show resolved Hide resolved
matter_server/client/models/node.py Outdated Show resolved Hide resolved
matter_server/client/models/node.py Outdated Show resolved Hide resolved
matter_server/client/models/node.py Outdated Show resolved Hide resolved
matter_server/server/device_controller.py Outdated Show resolved Hide resolved
@marcelveldt
Copy link
Contributor Author

marcelveldt commented Feb 21, 2023 •
edited

Next step is build a new SDK clusters wheel which includes the ALL_CLUSTERS and ALL_ATTRIBUTES lookup dicts.

@marcelveldt marcelveldt marked this pull request as ready for review February 21, 2023 22:45
@marcelveldt
Copy link
Contributor Author

wheels are ready and I've addressed the final bugs/feedback.

@MartinHjelmare
Copy link
Contributor

There are some lint failures from mypy.

@balloob balloob merged commit 0480738 into main Feb 22, 2023
@balloob balloob deleted the simplify-datamodel branch February 22, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcelveldt @MartinHjelmare @balloob