Add timeouts to sdk calls and subscription set-up #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelveldt
added
the
maintenance
agners
reviewed
Feb 29, 2024
There was a problem hiding this comment.
In general, the SDK should have it's own timeout. When we abort here on Matter Server side, the call will continue anyways... That said, I am not against adding this. It might help to find and analyze such long running calls. We just need to make sure that we also can identify those as this.
agners
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While skimming through user logs I noticed that sometimes a call to the sdk (especially the read attribute one) seems to be hanging forever. I think its good for detection and deadlock-preventing to add timeouts to the sdk calls.
I've set the default to 5 minutes per call. Now with a single executor thread handling all calls to the SDK that seems reasonable. If calls take (even) longer than 5 minutes to complete, something is seriously wrong.