Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and optimizes the Docker build #206

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

alex3305
Copy link
Contributor

This resolves issue #203 and also optimizes the Dockerfile to use less
resources. Also the current version from the Git repo is copied to
the Docker container for easy access.

I've taken the liberty to also update the DTLSSocket requirement to
version 0.1.7 which resolves an issue regarding cython. According to
their repo, nothing else has changed [1].

The RPi and RPiW Dockerfiles were not updated because of compatibility
reasons. I cannot easily test those files and do not want to break
anything.

References

  1. https://git.fslab.de/jkonra2m/tinydtls-cython/commits/master

@ggravlingen
Copy link
Member

Thank you! Travis fails due to a completely unrelated error, which I haven't seen before.

I've fixed this in the master branch now so please rebase onto that so that Travis builds. Following that, we can merge this PR.

This resolves issue home-assistant-libs#203 and also optimizes the Dockerfile to use less
resources. Also the current version from the Git repo is copied to
the Docker container for easy access.

I've taken the liberty to also update the DTLSSocket requirement to
version 0.1.7 which resolves an issue regarding cython. According to
their repo, nothing else has changed [1].

The RPi and RPiW Dockerfiles were not updated because of compatibility
reasons. I cannot easily test those files and do not want to break
anything.

**References**

 1. https://git.fslab.de/jkonra2m/tinydtls-cython/commits/master
@alex3305
Copy link
Contributor Author

@ggravlingen Working on it, same for the other PR :).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.019% when pulling b4ac8d2 on alex3305:dockerfile-fix into 506b9e8 on ggravlingen:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.019% when pulling b4ac8d2 on alex3305:dockerfile-fix into 506b9e8 on ggravlingen:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.019% when pulling b4ac8d2 on alex3305:dockerfile-fix into 506b9e8 on ggravlingen:master.

@ggravlingen ggravlingen merged commit 685027b into home-assistant-libs:master Nov 18, 2018
@ggravlingen
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants