Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid JSON cache by JSONSerialization NSString #60

Merged
merged 1 commit into from Apr 22, 2024
Merged

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Apr 15, 2024

@bgoncal bgoncal self-assigned this Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (b99c77e) to head (8231029).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   99.87%   99.87%           
=======================================
  Files          51       51           
  Lines        1631     1636    +5     
=======================================
+ Hits         1629     1634    +5     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacwest
Copy link
Member

zacwest commented Apr 15, 2024

Can you add a comment about why too?

@bgoncal
Copy link
Member Author

bgoncal commented Apr 16, 2024

@zacwest perhaps wait for feedback from users before merging it? home-assistant/iOS#2101

@bgoncal bgoncal merged commit 226008d into main Apr 22, 2024
5 checks passed
@bgoncal bgoncal deleted the avoid-json-cache branch April 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants