homematic: fix backup mv #2371
Merged
homematic: fix backup mv #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent backup fix introduced another error: mv complains about us trying to move a folder into its own subfolder. The script then aborts due to set -e. By ignoring the exit code of mv here we get the desired result (complete backup and no error in ui)
|
Hi @sdirkwinkel, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Oh. Didn't thought about that! So my bad. Thanks for the fix which I can approve. @pvizeli Please merge! |
pvizeli
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent backup fix introduced another error:
mv complains about us trying to move a folder into its own subfolder.
The script then aborts due to set -e. By ignoring the exit code of mv here
we get the desired result (complete backup and no error in ui)
cc @jens-maus